diff options
| author | Tejun Heo <tj@kernel.org> | 2011-11-22 00:32:22 +0400 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2011-11-22 00:32:22 +0400 |
| commit | 3a7cbd50f74907580eb47a8d08e1f29741b81abf (patch) | |
| tree | 515b7d9b9fa85c20ecf6779d563371b666a8b991 /Documentation/power | |
| parent | 50fb4f7fc907efff65eadb0b74387a9ffed6e849 (diff) | |
| download | linux-3a7cbd50f74907580eb47a8d08e1f29741b81abf.tar.xz | |
freezer: don't unnecessarily set PF_NOFREEZE explicitly
Some drivers set PF_NOFREEZE in their kthread functions which is
completely unnecessary and racy - some part of freezer code doesn't
consider cases where PF_NOFREEZE is set asynchronous to freezer
operations.
In general, there's no reason to allow setting PF_NOFREEZE explicitly.
Remove them and change the documentation to note that setting
PF_NOFREEZE directly isn't allowed.
-v2: Dropped change to twl4030-irq.c as it no longer uses PF_NOFREEZE.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: "Gustavo F. Padovan" <padovan@profusion.mobi>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: wwang <wei_wang@realsil.com.cn>
Diffstat (limited to 'Documentation/power')
| -rw-r--r-- | Documentation/power/freezing-of-tasks.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/power/freezing-of-tasks.txt b/Documentation/power/freezing-of-tasks.txt index 316c2ba187f4..587e0828053f 100644 --- a/Documentation/power/freezing-of-tasks.txt +++ b/Documentation/power/freezing-of-tasks.txt @@ -67,7 +67,7 @@ III. Which kernel threads are freezable? Kernel threads are not freezable by default. However, a kernel thread may clear PF_NOFREEZE for itself by calling set_freezable() (the resetting of PF_NOFREEZE -directly is strongly discouraged). From this point it is regarded as freezable +directly is not allowed). From this point it is regarded as freezable and must call try_to_freeze() in a suitable place. IV. Why do we do that? |