diff options
author | Darrick J. Wong <djwong@kernel.org> | 2021-02-02 22:13:58 +0300 |
---|---|---|
committer | Darrick J. Wong <djwong@kernel.org> | 2021-02-04 20:10:38 +0300 |
commit | 45068063efb7dd0a8d115c106aa05d9ab0946257 (patch) | |
tree | 913d3a1d29c620dfdf71218e4745523b61ef7a83 /Documentation/admin-guide | |
parent | 07aabd9c4a881276cf9b7b2d3a7f1d14dd832ed0 (diff) | |
download | linux-45068063efb7dd0a8d115c106aa05d9ab0946257.tar.xz |
xfs: fix incorrect root dquot corruption error when switching group/project quota types
While writing up a regression test for broken behavior when a chprojid
request fails, I noticed that we were logging corruption notices about
the root dquot of the group/project quota file at mount time when
testing V4 filesystems.
In commit afeda6000b0c, I was trying to improve ondisk dquot validation
by making sure that when we load an ondisk dquot into memory on behalf
of an incore dquot, the dquot id and type matches. Unfortunately, I
forgot that V4 filesystems only have two quota files, and can switch
that file between group and project quota types at mount time. When we
perform that switch, we'll try to load the default quota limits from the
root dquot prior to running quotacheck and log a corruption error when
the types don't match.
This is inconsequential because quotacheck will reset the second quota
file as part of doing the switch, but we shouldn't leave scary messages
in the kernel log.
Fixes: afeda6000b0c ("xfs: validate ondisk/incore dquot flags")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Diffstat (limited to 'Documentation/admin-guide')
0 files changed, 0 insertions, 0 deletions