diff options
| author | Jan Kara <jack@suse.cz> | 2011-12-09 03:08:58 +0400 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2012-01-09 16:52:07 +0400 |
| commit | ef6919c283257155def420bd247140e9fd2e9843 (patch) | |
| tree | 49c929bcb5b8be103a4ea8fe9964d0e02a0ec740 | |
| parent | 1415dd8705394399d59a3df1ab48d149e1e41e77 (diff) | |
| download | linux-ef6919c283257155def420bd247140e9fd2e9843.tar.xz | |
ext2: Fix error handling on inode bitmap corruption
When insert_inode_locked() fails in ext2_new_inode() it most likely means inode
bitmap got corrupted and we allocated again inode which is already in use. Also
doing unlock_new_inode() during error recovery is wrong since the inode does
not have I_NEW set. Fix the problem by informing about filesystem error and
jumping to fail: (instead of fail_drop:) which doesn't call unlock_new_inode().
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/ext2/ialloc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c index c4e81dfb74ba..78502c166814 100644 --- a/fs/ext2/ialloc.c +++ b/fs/ext2/ialloc.c @@ -573,8 +573,11 @@ got: inode->i_generation = sbi->s_next_generation++; spin_unlock(&sbi->s_next_gen_lock); if (insert_inode_locked(inode) < 0) { - err = -EINVAL; - goto fail_drop; + ext2_error(sb, "ext2_new_inode", + "inode number already in use - inode=%lu", + (unsigned long) ino); + err = -EIO; + goto fail; } dquot_initialize(inode); |