diff options
| author | Johan Hovold <johan@kernel.org> | 2025-09-25 18:02:19 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-01-08 12:14:42 +0300 |
| commit | 9b9e152a87ca4ae797d74d92232b159cb7ca7786 (patch) | |
| tree | 59bdbde5bb1c113aa9859608e71e3ca086b0ceda | |
| parent | eb1f3a6ab3efee2b52361879cdc2dc6b11f499c0 (diff) | |
| download | linux-9b9e152a87ca4ae797d74d92232b159cb7ca7786.tar.xz | |
mfd: altera-sysmgr: Fix device leak on sysmgr regmap lookup
commit ccb7cd3218e48665f3c7e19eede0da5f069c323d upstream.
Make sure to drop the reference taken to the sysmgr platform device when
retrieving its driver data.
Note that holding a reference to a device does not prevent its driver
data from going away.
Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Cc: stable@vger.kernel.org # 5.2
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/mfd/altera-sysmgr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index fb5f988e61f3..90c6902d537d 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -117,6 +117,8 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, sysmgr = dev_get_drvdata(dev); + put_device(dev); + return sysmgr->regmap; } EXPORT_SYMBOL_GPL(altr_sysmgr_regmap_lookup_by_phandle); |