diff options
| author | Wen Yang <yellowriver2010@hotmail.com> | 2019-02-09 13:41:09 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-02-14 16:12:07 +0300 |
| commit | 1c3816a194870e7a6622345dab7fb56c7d708613 (patch) | |
| tree | 0ed941bc9963653f26d8cc531815974d7278dea4 | |
| parent | 0f928c19b646f6af39ccf7481a546e5da616bb78 (diff) | |
| download | linux-1c3816a194870e7a6622345dab7fb56c7d708613.tar.xz | |
ASoC: stm32: sai: add missing put_device()
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Fixes: 7dd0d835582f ("ASoC: stm32: sai: simplify sync modes management")
Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
Acked-by: Olivier Moysan <olivier.moysan@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/stm/stm32_sai.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c index bcb35cae2a2c..14c9591aae42 100644 --- a/sound/soc/stm/stm32_sai.c +++ b/sound/soc/stm/stm32_sai.c @@ -112,16 +112,21 @@ static int stm32_sai_set_sync(struct stm32_sai_data *sai_client, if (!sai_provider) { dev_err(&sai_client->pdev->dev, "SAI sync provider data not found\n"); - return -EINVAL; + ret = -EINVAL; + goto out_put_dev; } /* Configure sync client */ ret = stm32_sai_sync_conf_client(sai_client, synci); if (ret < 0) - return ret; + goto out_put_dev; /* Configure sync provider */ - return stm32_sai_sync_conf_provider(sai_provider, synco); + ret = stm32_sai_sync_conf_provider(sai_provider, synco); + +out_put_dev: + put_device(&pdev->dev); + return ret; } static int stm32_sai_probe(struct platform_device *pdev) |