diff options
| author | Muhammad Usama Anjum <usama.anjum@collabora.com> | 2024-09-06 13:28:39 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-09-10 03:21:47 +0300 |
| commit | 4c8002277167125078e6b9b90137bdf443ebaa08 (patch) | |
| tree | 2137415edfd0fd585109935196199fb92fedb76b | |
| parent | b3c9e65eb227269ed72a115ba22f4f51b4e62b4d (diff) | |
| download | linux-4c8002277167125078e6b9b90137bdf443ebaa08.tar.xz | |
fou: fix initialization of grc
The grc must be initialize first. There can be a condition where if
fou is NULL, goto out will be executed and grc would be used
uninitialized.
Fixes: 7e4196935069 ("fou: Fix null-ptr-deref in GRO.")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20240906102839.202798-1-usama.anjum@collabora.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/ipv4/fou_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/fou_core.c b/net/ipv4/fou_core.c index 78b869b31492..3e30745e2c09 100644 --- a/net/ipv4/fou_core.c +++ b/net/ipv4/fou_core.c @@ -336,11 +336,11 @@ static struct sk_buff *gue_gro_receive(struct sock *sk, struct gro_remcsum grc; u8 proto; + skb_gro_remcsum_init(&grc); + if (!fou) goto out; - skb_gro_remcsum_init(&grc); - off = skb_gro_offset(skb); len = off + sizeof(*guehdr); |