summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZeng Jingxiang <linuszeng@tencent.com>2022-07-27 10:31:19 +0300
committerRobert Foss <robert.foss@linaro.org>2022-08-08 12:22:14 +0300
commitef8886f321c5dab8124b9153d25afa2a71d05323 (patch)
tree318c2b45e3bbf4a357039616c88a2259a58117cc
parentde40c281fe0b6babf3d1a25e034525a23e125d0c (diff)
downloadlinux-ef8886f321c5dab8124b9153d25afa2a71d05323.tar.xz
gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()
A NULL check for bridge->encoder shows that it may be NULL, but it already been dereferenced on all paths leading to the check. 812 if (!bridge->encoder) { Dereference the pointer bridge->encoder. 810 drm_connector_attach_encoder(&lt9611->connector, bridge->encoder); Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com> Signed-off-by: Robert Foss <robert.foss@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20220727073119.1578972-1-zengjx95@gmail.com
-rw-r--r--drivers/gpu/drm/bridge/lontium-lt9611.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index 8a60e83482a0..5fccacc159f0 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -813,13 +813,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961
drm_connector_helper_add(&lt9611->connector,
&lt9611_bridge_connector_helper_funcs);
- drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);
if (!bridge->encoder) {
DRM_ERROR("Parent encoder object not found");
return -ENODEV;
}
+ drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);
+
return 0;
}