diff options
| author | Jason Wang <jasowang@redhat.com> | 2013-11-25 13:19:04 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-29 03:32:22 +0400 |
| commit | cd3e22b75c01fe1e075d91504b29019a05d8d373 (patch) | |
| tree | e5765bb618f6808c16708416a15645134402c7ec | |
| parent | 167f76a87743dfaf1fec954db5233715ddad49ef (diff) | |
| download | linux-cd3e22b75c01fe1e075d91504b29019a05d8d373.tar.xz | |
macvtap: fix tx_dropped counting error
After commit 8ffab51b3dfc54876f145f15b351c41f3f703195
(macvlan: lockless tx path), tx stat counter were converted to percpu stat
structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the
management won't notice the dropping packet in macvtap tx path.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/macvtap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index dc76670c2f2a..0605da8e25f5 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -744,7 +744,7 @@ err: rcu_read_lock(); vlan = rcu_dereference(q->vlan); if (vlan) - vlan->dev->stats.tx_dropped++; + this_cpu_inc(vlan->pcpu_stats->tx_dropped); rcu_read_unlock(); return err; |