diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-11-29 15:08:00 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-12-04 10:32:05 +0400 |
| commit | a1de22191bc4c47ff50ef3274295f4384074696b (patch) | |
| tree | dc204b3ce1a8091a6abf1826f234cdf13204d610 | |
| parent | 01e23742b276cb8cb53bf727c4b1c50fae1860e7 (diff) | |
| download | linux-a1de22191bc4c47ff50ef3274295f4384074696b.tar.xz | |
enic: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/cisco/enic/enic_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 1fe5df0284a6..2fd9db4b1be5 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -2379,7 +2379,7 @@ static int __devinit enic_probe(struct pci_dev *pdev, #endif /* Allocate structure for port profiles */ - enic->pp = kzalloc(num_pps * sizeof(*enic->pp), GFP_KERNEL); + enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL); if (!enic->pp) { pr_err("port profile alloc failed, aborting\n"); err = -ENOMEM; |