diff options
| author | Jens Axboe <axboe@fb.com> | 2016-08-25 00:38:01 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-08-25 00:38:01 +0300 |
| commit | 0e87e58bf60edb6bb28e493c7a143f41b091a5e5 (patch) | |
| tree | f7da272dc09742028a98b3503ad32bf1f2db3c8d | |
| parent | e57690fe009b2ab0cee8a57f53be634540e49c9d (diff) | |
| download | linux-0e87e58bf60edb6bb28e493c7a143f41b091a5e5.tar.xz | |
blk-mq: improve warning for running a queue on the wrong CPU
__blk_mq_run_hw_queue() currently warns if we are running the queue on a
CPU that isn't set in its mask. However, this can happen if a CPU is
being offlined, and the workqueue handling will place the work on CPU0
instead. Improve the warning so that it only triggers if the batch cpu
in the hardware queue is currently online. If it triggers for that
case, then it's indicative of a flow problem in blk-mq, so we want to
retain it for that case.
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | block/blk-mq.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 729169d022fc..13f5a6c1de76 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -793,11 +793,12 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx) struct list_head *dptr; int queued; - WARN_ON(!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask)); - if (unlikely(test_bit(BLK_MQ_S_STOPPED, &hctx->state))) return; + WARN_ON(!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask) && + cpu_online(hctx->next_cpu)); + hctx->run++; /* |