diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-18 08:05:03 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-08-19 21:29:23 +0300 |
| commit | 093db9cda7b695f963cd7b468ed1488063548ce2 (patch) | |
| tree | 8ffbcec706b96e86b7c0bc4d2523e8548492ed20 | |
| parent | 44a696de720d6917f1d1844a05757624295b81c0 (diff) | |
| download | linux-093db9cda7b695f963cd7b468ed1488063548ce2.tar.xz | |
net: microchip: vcap api: Always return ERR_PTR for vcap_get_rule()
As Simon Horman suggests, update vcap_get_rule() to always
return an ERR_PTR() and update the error detection conditions to
use IS_ERR(), which would be more cleaner in this case.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Suggested-by: Simon Horman <horms@kernel.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/microchip/vcap/vcap_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c index a7b43f99bc80..300fe1a93dce 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c @@ -2429,7 +2429,7 @@ struct vcap_rule *vcap_get_rule(struct vcap_control *vctrl, u32 id) elem = vcap_get_locked_rule(vctrl, id); if (!elem) - return NULL; + return ERR_PTR(-ENOENT); rule = vcap_decode_rule(elem); mutex_unlock(&elem->admin->lock); |