diff options
| author | Albert Hsieh <wen.hsieh@broadcom.com> | 2017-11-20 06:26:26 +0300 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2017-12-16 00:26:48 +0300 |
| commit | e44b9a9c135727f3410e029910275f40681dc8bc (patch) | |
| tree | 94fbaa2bdeadfc3e4d7671abccc3c7d4e3cfffc4 | |
| parent | fdf2e821052958a114618a95ab18a300d0b080cb (diff) | |
| download | linux-e44b9a9c135727f3410e029910275f40681dc8bc.tar.xz | |
mtd: nand: brcmnand: Zero bitflip is not an error
A negative return value of brcmstb_nand_verify_erased_page() indicates a
real bitflip error of an erased page, and other return values (>= 0) show
the corrected bitflip number. Zero return value means no bitflip, but the
current driver code treats it as an error, and eventually leads to
falsely reported ECC error.
Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflip")
Signed-off-by: Albert Hsieh <wen.hsieh@broadcom.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | drivers/mtd/nand/brcmnand/brcmnand.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index e0eb51d8c012..dd56a671ea42 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -1763,7 +1763,7 @@ try_dmaread: err = brcmstb_nand_verify_erased_page(mtd, chip, buf, addr); /* erased page bitflips corrected */ - if (err > 0) + if (err >= 0) return err; } |