diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2021-10-06 14:06:32 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-07 17:45:27 +0300 |
| commit | e131bc58868a529c1c97567fc6d0d8855bdb3ffd (patch) | |
| tree | 1b4939e5d04078c2c409b7072cf67b0f3d39694e | |
| parent | 247ac640739dda167a127a2ecb158595695ffd7d (diff) | |
| download | linux-e131bc58868a529c1c97567fc6d0d8855bdb3ffd.tar.xz | |
ASoC: SOF: intel: atom: No need to do a DSP dump in atom_run()
The core already prints a dump if the DSP failed to start in
snd_sof_run_firmware(), there is no need to print it locally as well.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-7-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/sof/intel/atom.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/sound/soc/sof/intel/atom.c b/sound/soc/sof/intel/atom.c index d8804efede5e..74c630bb9847 100644 --- a/sound/soc/sof/intel/atom.c +++ b/sound/soc/sof/intel/atom.c @@ -283,11 +283,8 @@ int atom_run(struct snd_sof_dev *sdev) break; msleep(100); } - if (tries < 0) { - dev_err(sdev->dev, "error: unable to run DSP firmware\n"); - atom_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX); + if (tries < 0) return -ENODEV; - } /* return init core mask */ return 1; |