diff options
| author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-09-26 03:59:08 +0400 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-09-26 22:35:28 +0400 |
| commit | 45223fd77c2b39d05dd7f1aaabf614abb1770bbe (patch) | |
| tree | dd3f866f1d5c206a29d4aea31e687a2fe9bb1fd2 | |
| parent | 53aefd3fc31f08487f6941282ef6611413e02e43 (diff) | |
| download | linux-45223fd77c2b39d05dd7f1aaabf614abb1770bbe.tar.xz | |
[SCSI] Signdness issue in drivers/scsi/osst.c
another signdness warning from gcc 4.1
drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
The problem is that blk is defined as unsigned, but all usages of it are
normal int cases. osst_get_frame_position() and osst_get_sector() return ints
and can return negative values. If blk stays an unsigned int, the error check
is useless.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| -rw-r--r-- | drivers/scsi/osst.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 4a2fed350d4e..9ecb323ebae8 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -4843,8 +4843,7 @@ static int os_scsi_tape_close(struct inode * inode, struct file * filp) static int osst_ioctl(struct inode * inode,struct file * file, unsigned int cmd_in, unsigned long arg) { - int i, cmd_nr, cmd_type, retval = 0; - unsigned int blk; + int i, cmd_nr, cmd_type, blk, retval = 0; struct st_modedef * STm; struct st_partstat * STps; struct osst_request * SRpnt = NULL; |