diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2008-08-19 08:31:46 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-08-19 08:31:46 +0400 |
| commit | fab00c5d15091546be681426c60b2ed2c10513bf (patch) | |
| tree | b2b2933ae23fdc33410b48f00c0b7a5f6fc76bad | |
| parent | cb1cb5c47457ff2b604dac2da44cab4d39d11459 (diff) | |
| download | linux-fab00c5d15091546be681426c60b2ed2c10513bf.tar.xz | |
netfilter: ctnetlink: sleepable allocation with spin lock bh
This patch removes a GFP_KERNEL allocation while holding a spin lock with
bottom halves disabled in ctnetlink_change_helper().
This problem was introduced in 2.6.23 with the netfilter extension
infrastructure.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index a5b95ccb3ce7..a8752031adcb 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -968,7 +968,7 @@ ctnetlink_change_helper(struct nf_conn *ct, struct nlattr *cda[]) /* need to zero data of old helper */ memset(&help->help, 0, sizeof(help->help)); } else { - help = nf_ct_helper_ext_add(ct, GFP_KERNEL); + help = nf_ct_helper_ext_add(ct, GFP_ATOMIC); if (help == NULL) return -ENOMEM; } |