diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2010-12-29 17:55:03 +0300 |
|---|---|---|
| committer | Chris Mason <chris.mason@oracle.com> | 2011-01-16 19:30:20 +0300 |
| commit | 6f88a4403def422bd8e276ddf6863d6ac71435d2 (patch) | |
| tree | 8fe01d61977e0113cc0a4fa77b7df7f8dfeecad9 | |
| parent | f690efb1aa2a961dd6655529c1797fcac60ad6d9 (diff) | |
| download | linux-6f88a4403def422bd8e276ddf6863d6ac71435d2.tar.xz | |
btrfs: Require CAP_SYS_ADMIN for filesystem rebalance
Filesystem rebalancing (BTRFS_IOC_BALANCE) affects the entire
filesystem and may run uninterruptibly for a long time. This does not
seem to be something that an unprivileged user should be able to do.
Reported-by: Aron Xu <happyaron.xu@gmail.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
| -rw-r--r-- | fs/btrfs/volumes.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e8be478178aa..f2d2f4ccc738 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -22,6 +22,7 @@ #include <linux/blkdev.h> #include <linux/random.h> #include <linux/iocontext.h> +#include <linux/capability.h> #include <asm/div64.h> #include "compat.h" #include "ctree.h" @@ -2024,6 +2025,9 @@ int btrfs_balance(struct btrfs_root *dev_root) if (dev_root->fs_info->sb->s_flags & MS_RDONLY) return -EROFS; + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + mutex_lock(&dev_root->fs_info->volume_mutex); dev_root = dev_root->fs_info->dev_root; |