summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-04-01 17:38:44 +0400
committerDavid S. Miller <davem@davemloft.net>2014-04-02 00:25:52 +0400
commitca231f838870e9c83aaf2c0eff136150cd97b412 (patch)
treeceaa9f41cb44d5812f3f0586e28b34c45d6dbdce
parent52ad762b85ed7947ec9eff6b036eb985352f6874 (diff)
downloadlinux-ca231f838870e9c83aaf2c0eff136150cd97b412.tar.xz
net: sxgbe: sxgbe_mdio_register() frees the bus
"err" is always zero at this point so we always unregister and free the mdio_bus before returning success. This seems like left over code and I have deleted it. Fixes: 1edb9ca69e8a ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c
index b0eb0a2c52ca..01af2cbb479d 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c
@@ -219,13 +219,6 @@ int sxgbe_mdio_register(struct net_device *ndev)
}
}
- if (!err) {
- netdev_err(ndev, "PHY not found\n");
- mdiobus_unregister(mdio_bus);
- mdiobus_free(mdio_bus);
- goto mdiobus_err;
- }
-
priv->mii = mdio_bus;
return 0;