summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Kepplinger <martink@posteo.de>2014-10-29 22:22:56 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-07 21:25:52 +0300
commit32eca22180804f71b06b63fd29b72f58be8b3c47 (patch)
tree48a5b4cbe53367e1e9b05d4fbbbd89ae02f62dfe
parent04a258c162a85c0f4ae56be67634dc43c9a4fa9b (diff)
downloadlinux-32eca22180804f71b06b63fd29b72f58be8b3c47.tar.xz
misc: always assign miscdevice to file->private_data in open()
As of now, a miscdevice driver has to provide an implementation of the open() file operation if it wants to have misc_open() assign a pointer to struct miscdevice to file->private_data for other file operations to use (given the user calls open()). This leads to situations where a miscdevice driver that doesn't need internal operations during open() has to implement open() that only returns immediately, in order to use the data in private_data in other fops. This provides consistent behaviour for miscdevice developers and will always provide the pointer in private_data. A driver's open() fop would, of course, just overwrite it, when using private_data itself. Signed-off-by: Martin Kepplinger <martink@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/char/misc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ffa97d261cf3..205ad4c58470 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -142,8 +142,8 @@ static int misc_open(struct inode * inode, struct file * file)
err = 0;
replace_fops(file, new_fops);
+ file->private_data = c;
if (file->f_op->open) {
- file->private_data = c;
err = file->f_op->open(inode,file);
}
fail: