diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-03-23 00:36:44 +0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2013-04-03 23:32:32 +0400 |
| commit | a7823c797b4d29727499f0a75ddf3ed07af8ad0a (patch) | |
| tree | d5a4d2cb12ef87e91296fac1f4765394ff9a147f | |
| parent | ff7c4b3693cbc7e938f49ed89e2f649a33f03ed1 (diff) | |
| download | linux-a7823c797b4d29727499f0a75ddf3ed07af8ad0a.tar.xz | |
SUNRPC/cache: add module_put() on error path in cache_open()
If kmalloc() fails in cache_open(), module cd->owner left locked.
The patch adds module_put(cd->owner) on this path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | net/sunrpc/cache.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 25d58e766014..1d3c5144a331 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -986,8 +986,10 @@ static int cache_open(struct inode *inode, struct file *filp, nonseekable_open(inode, filp); if (filp->f_mode & FMODE_READ) { rp = kmalloc(sizeof(*rp), GFP_KERNEL); - if (!rp) + if (!rp) { + module_put(cd->owner); return -ENOMEM; + } rp->offset = 0; rp->q.reader = 1; atomic_inc(&cd->readers); |