diff options
| author | Imre Deak <imre.deak@intel.com> | 2013-04-24 20:04:57 +0400 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2013-05-01 10:08:18 +0400 |
| commit | 98b76231d7ef49c71c7fea354f00c619ab2c1be4 (patch) | |
| tree | 0fd0a1fe3a178c58181b5b1f848ceb4f933f11ad | |
| parent | 33896bf3207d8812274747b8b96776d27082e580 (diff) | |
| download | linux-98b76231d7ef49c71c7fea354f00c619ab2c1be4.tar.xz | |
drm/prime: warn for non-empty handle lookup list during drm file release
drm_gem_release should release all handles connected to the drm file and
so should also release the prime lookup entries of these handles. So
just WARN if this isn't the case.
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/drm_prime.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 71c7315ca00f..dcde35231e25 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -488,11 +488,8 @@ EXPORT_SYMBOL(drm_prime_init_file_private); void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv) { - struct drm_prime_member *member, *safe; - list_for_each_entry_safe(member, safe, &prime_fpriv->head, entry) { - list_del(&member->entry); - kfree(member); - } + /* by now drm_gem_release should've made sure the list is empty */ + WARN_ON(!list_empty(&prime_fpriv->head)); } EXPORT_SYMBOL(drm_prime_destroy_file_private); |