summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2019-01-13 12:44:50 +0300
committerRob Herring <robh@kernel.org>2019-01-16 21:49:53 +0300
commit28b170e88bc0c7509e6724717c15cb4b5686026e (patch)
treebbd798f3fbcf11f9169c166b6c85b51b70f36963
parent8217724eb7c51bbec351b23cbc924577b2f4b8e6 (diff)
downloadlinux-28b170e88bc0c7509e6724717c15cb4b5686026e.tar.xz
OF: properties: add missing of_node_put
Add an of_node_put when the result of of_graph_get_remote_port_parent is not available. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @r exists@ local idexpression e; expression x; @@ e = of_graph_get_remote_port_parent(...); ... when != x = e when != true e == NULL when != of_node_put(e) when != of_fwnode_handle(e) ( return e; | *return ...; ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Cc: stable@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org>
-rw-r--r--drivers/of/property.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 08430031bd28..8631efa1daa1 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -806,6 +806,7 @@ struct device_node *of_graph_get_remote_node(const struct device_node *node,
if (!of_device_is_available(remote)) {
pr_debug("not available for remote node\n");
+ of_node_put(remote);
return NULL;
}