diff options
| author | Nikolay Borisov <nborisov@suse.com> | 2017-09-28 10:53:17 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-10-30 14:27:58 +0300 |
| commit | 9417ebc8a676487c6ec8825f92fb28f7dbeb5f4b (patch) | |
| tree | ad38ec9df2f1766b55a31df3c552d931b5ec3518 | |
| parent | 7132a262595a43abd483f1c5139afc038c67fbbb (diff) | |
| download | linux-9417ebc8a676487c6ec8825f92fb28f7dbeb5f4b.tar.xz | |
btrfs: Explicitly handle btrfs_update_root failure
btrfs_udpate_root can fail and it aborts the transaction, the correct
way to handle an aborted transaction is to explicitly end with
btrfs_end_transaction. Even now the code is correct since
btrfs_commit_transaction would handle an aborted transaction but this is
more of an implementation detail. So let's be explicit in handling
failure in btrfs_update_root.
Furthermore btrfs_commit_transaction can also fail and by ignoring it's
return value we could have left the in-memory copy of the root item in
an inconsistent state. So capture the error value which allows us to
correctly revert the RO/RW flags in case of commit failure.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/ioctl.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index feab6f61cb97..86728e06e263 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1827,8 +1827,13 @@ static noinline int btrfs_ioctl_subvol_setflags(struct file *file, ret = btrfs_update_root(trans, fs_info->tree_root, &root->root_key, &root->root_item); + if (ret < 0) { + btrfs_end_transaction(trans); + goto out_reset; + } + + ret = btrfs_commit_transaction(trans); - btrfs_commit_transaction(trans); out_reset: if (ret) btrfs_set_root_flags(&root->root_item, root_flags); |