diff options
author | William Wu <wulf@rock-chips.com> | 2016-11-15 06:54:07 +0300 |
---|---|---|
committer | Kishon Vijay Abraham I <kishon@ti.com> | 2016-11-18 15:49:15 +0300 |
commit | 882e1492c7caac8b2f41c50efc2648ff2cd88b72 (patch) | |
tree | 74c95c4f985dba5d8638aa9ec9db192899813e84 | |
parent | ae9fc711d3d0fe62ffeeb83f24e79e08eafd733f (diff) | |
download | linux-882e1492c7caac8b2f41c50efc2648ff2cd88b72.tar.xz |
phy: rockchip-inno-usb2: correct 480MHz output clock stable time
We found that the system crashed due to 480MHz output clock of
USB2 PHY was unstable after clock had been enabled by gpu module.
Theoretically, 1 millisecond is a critical value for 480MHz
output clock stable time, so we try to change the delay time
to 1.2 millisecond to avoid this issue.
And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct
clk_ops callback") used prepare callbacks instead of enable
callbacks to support gate a clk if the operation may sleep. So
we can switch from delay to sleep functions.
Also fix a spelling error from "waitting" to "waiting".
Signed-off-by: William Wu <wulf@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
-rw-r--r-- | drivers/phy/phy-rockchip-inno-usb2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c index 486a0e4290b2..eb89de59b68f 100644 --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -266,8 +266,8 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw) if (ret) return ret; - /* waitting for the clk become stable */ - mdelay(1); + /* waiting for the clk become stable */ + usleep_range(1200, 1300); } return 0; |