diff options
| author | Sowmini Varadhan <sowmini.varadhan@oracle.com> | 2017-07-06 18:15:07 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-07-08 13:16:16 +0300 |
| commit | 0ffdaf5b41cf4435ece14d1d3e977ce69012a20d (patch) | |
| tree | 606445d216e1fb481b1d6e8d5f1fb264d41fa4f9 | |
| parent | 0933a578cd55b02dc80f219dc8f2efb17ec61c9a (diff) | |
| download | linux-0ffdaf5b41cf4435ece14d1d3e977ce69012a20d.tar.xz | |
net/sock: add WARN_ON(parent->sk) in sock_graft()
sock_graft() unilaterally sets up parent->sk based on the
assumption that the existing parent->sk is null. If this
condition is not true, then the existing parent->sk would
be leaked, so add a WARN_ON() to alert callers who may fall
in this category.
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/net/sock.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/net/sock.h b/include/net/sock.h index 48e4d5c38f85..8c85791fc196 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1697,6 +1697,7 @@ static inline void sock_orphan(struct sock *sk) static inline void sock_graft(struct sock *sk, struct socket *parent) { + WARN_ON(parent->sk); write_lock_bh(&sk->sk_callback_lock); sk->sk_wq = parent->wq; parent->sk = sk; |