diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-06-23 20:23:00 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-06-24 21:29:57 +0300 |
| commit | b01d550663fa5fd40a1785b0f1211fb657892edf (patch) | |
| tree | 77d0269e361d2d9ef505ed45bcca93ff72405d90 | |
| parent | d74d99229f4d48f42d674f7a8a1137179efd67ac (diff) | |
| download | linux-b01d550663fa5fd40a1785b0f1211fb657892edf.tar.xz | |
spi: Fix self assignment issue with ancillary->mode
There is an assignment of ancillary->mode to itself which looks
dubious since the proceeding comment states that the speed and
mode is taken over from the SPI main device, indicating that
ancillary->mode should assigned using the value spi->mode.
Fix this.
Addresses-Coverity: ("Self assignment")
Fixes: 0c79378c0199 ("spi: add ancillary device support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210623172300.161484-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 572ad95c1d4f..c296f08b36c1 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2183,7 +2183,7 @@ struct spi_device *spi_new_ancillary_device(struct spi_device *spi, /* Take over SPI mode/speed from SPI main device */ ancillary->max_speed_hz = spi->max_speed_hz; - ancillary->mode = ancillary->mode; + ancillary->mode = spi->mode; /* Register the new device */ rc = spi_add_device_locked(ancillary); |