diff options
| author | Steve Twiss <stwiss.opensource@diasemi.com> | 2019-02-26 18:51:28 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-03-13 18:13:01 +0300 |
| commit | f7a621728a6a23bfd2c6ac4d3e42e1303aefde0f (patch) | |
| tree | c29177796187601c57fd3c2319403c36bd0ec9f0 | |
| parent | ae15c519a6b97fff087cf69502bdf8fc8892f4be (diff) | |
| download | linux-f7a621728a6a23bfd2c6ac4d3e42e1303aefde0f.tar.xz | |
regulator: wm831x isink: Fix notifier mutex lock warning
The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.
Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.
Fixes: d4d6b722e780 ("regulator: Add WM831x ISINK support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/wm831x-isink.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/regulator/wm831x-isink.c b/drivers/regulator/wm831x-isink.c index 6dd891d7eee3..11f351191dba 100644 --- a/drivers/regulator/wm831x-isink.c +++ b/drivers/regulator/wm831x-isink.c @@ -140,9 +140,11 @@ static irqreturn_t wm831x_isink_irq(int irq, void *data) { struct wm831x_isink *isink = data; + regulator_lock(isink->regulator); regulator_notifier_call_chain(isink->regulator, REGULATOR_EVENT_OVER_CURRENT, NULL); + regulator_unlock(isink->regulator); return IRQ_HANDLED; } |