diff options
| author | Simon Horman <simon.horman@netronome.com> | 2017-04-03 22:42:58 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-04 00:46:45 +0300 |
| commit | ac6a3722fed67c658a435187d0254ae119d845d3 (patch) | |
| tree | b79389a819445a306c89422b61ae74c1da375505 | |
| parent | 75514b6654859e0130b512396dc964d2a9e84967 (diff) | |
| download | linux-ac6a3722fed67c658a435187d0254ae119d845d3.tar.xz | |
flow dissector: correct size of storage for ARP
The last argument to __skb_header_pointer() should be a buffer large
enough to store struct arphdr. This can be a pointer to a struct arphdr
structure. The code was previously using a pointer to a pointer to
struct arphdr.
By my counting the storage available both before and after is 8 bytes on
x86_64.
Fixes: 55733350e5e8 ("flow disector: ARP support")
Reported-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/flow_dissector.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index c35aae13c8d2..d98d4998213d 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -390,7 +390,7 @@ mpls: unsigned char ar_tip[4]; } *arp_eth, _arp_eth; const struct arphdr *arp; - struct arphdr *_arp; + struct arphdr _arp; arp = __skb_header_pointer(skb, nhoff, sizeof(_arp), data, hlen, &_arp); |