diff options
| author | Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2021-06-02 13:15:04 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-18 11:02:52 +0300 |
| commit | 8478b361dfc567d5b9506749ccd24c225cf9b530 (patch) | |
| tree | 988f6b44e20c4cf3a5556f37a9e83df4d15e8201 | |
| parent | abc57d8def3a74c40f15ab1e0e313ecdacf8fe5c (diff) | |
| download | linux-8478b361dfc567d5b9506749ccd24c225cf9b530.tar.xz | |
rtnetlink: Fix missing error code in rtnl_bridge_notify()
[ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.
Eliminate the follow smatch warning:
net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/core/rtnetlink.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 3485b16a7ff3..9ad046917b34 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4833,8 +4833,10 @@ static int rtnl_bridge_notify(struct net_device *dev) if (err < 0) goto errout; - if (!skb->len) + if (!skb->len) { + err = -EINVAL; goto errout; + } rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC); return 0; |