diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-08-17 22:35:16 +0300 |
|---|---|---|
| committer | Mike Marshall <hubcap@omnibond.com> | 2017-09-14 21:58:31 +0300 |
| commit | 0b08273c8ab7e688832120c4817b1adfdc56e231 (patch) | |
| tree | d0da15cfafc361208379e07dc2975f2777e287d7 | |
| parent | 5e273a0e06ee5a50bb9cd40026177feca060c101 (diff) | |
| download | linux-0b08273c8ab7e688832120c4817b1adfdc56e231.tar.xz | |
orangefs: Adjust three checks for null pointers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
| -rw-r--r-- | fs/orangefs/acl.c | 2 | ||||
| -rw-r--r-- | fs/orangefs/xattr.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c index 45f27cf51fd8..9108ef433e6d 100644 --- a/fs/orangefs/acl.c +++ b/fs/orangefs/acl.c @@ -35,7 +35,7 @@ struct posix_acl *orangefs_get_acl(struct inode *inode, int type) * I don't do that for now. */ value = kmalloc(ORANGEFS_MAX_XATTR_VALUELEN, GFP_KERNEL); - if (value == NULL) + if (!value) return ERR_PTR(-ENOMEM); gossip_debug(GOSSIP_ACL_DEBUG, diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c index fed0e9aae23b..81ac88bb91ff 100644 --- a/fs/orangefs/xattr.c +++ b/fs/orangefs/xattr.c @@ -239,7 +239,7 @@ int orangefs_inode_setxattr(struct inode *inode, const char *name, internal_flag = convert_to_internal_xattr_flags(flags); /* This is equivalent to a removexattr */ - if (size == 0 && value == NULL) { + if (size == 0 && !value) { gossip_debug(GOSSIP_XATTR_DEBUG, "removing xattr (%s)\n", name); @@ -311,7 +311,7 @@ ssize_t orangefs_listxattr(struct dentry *dentry, char *buffer, size_t size) int i = 0; int returned_count = 0; - if (size > 0 && buffer == NULL) { + if (size > 0 && !buffer) { gossip_err("%s: bogus NULL pointers\n", __func__); return -EINVAL; } |