diff options
| author | Joe Carnuccio <joe.carnuccio@qlogic.com> | 2011-08-16 22:31:51 +0400 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2011-08-29 11:14:56 +0400 |
| commit | 1fedd80f9c2e1da9e6c2fa6a1b75ad077c70f291 (patch) | |
| tree | fa9b4e0c7b03044f42f08cb3b54311a4e9d23ed8 | |
| parent | 491118dff9aeb207408bd42aa4897bc2c145747f (diff) | |
| download | linux-1fedd80f9c2e1da9e6c2fa6a1b75ad077c70f291.tar.xz | |
[SCSI] qla2xxx: Correction to sysfs edc interface.
Corrects the return value for the cases where read/write edc fails;
this prevents sysfs from retrying the operation until forever.
Corrects the printk width specifier for the first byte of buf.
Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_attr.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index df0002f78805..c9c42a65566f 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -668,9 +668,9 @@ qla2x00_sysfs_write_edc(struct file *filp, struct kobject *kobj, dev, adr, len, opt); if (rval != QLA_SUCCESS) { ql_log(ql_log_warn, vha, 0x7074, - "Unable to write EDC (%x) %02x:%04x:%02x:%02x\n", + "Unable to write EDC (%x) %02x:%04x:%02x:%02hhx\n", rval, dev, adr, opt, len, buf[8]); - return 0; + return -EINVAL; } return count; @@ -727,7 +727,7 @@ qla2x00_sysfs_write_edc_status(struct file *filp, struct kobject *kobj, ql_log(ql_log_info, vha, 0x7075, "Unable to write EDC status (%x) %02x:%04x:%02x.\n", rval, dev, adr, opt, len); - return 0; + return -EINVAL; } ha->edc_data_len = len; |