summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLarry Woodman <lwoodman@redhat.com>2006-11-04 03:05:45 +0300
committerDavid S. Miller <davem@sunset.davemloft.net>2006-11-06 01:11:32 +0300
commitdb38c179a759a9c4722525e8c9f09ac80e372377 (patch)
tree92edcdcec2fea73cd449a00e6e000ad5e53fec7b
parent0f37c6057414fb68024793966b1dcb6a135cb844 (diff)
downloadlinux-db38c179a759a9c4722525e8c9f09ac80e372377.tar.xz
[NET]: __alloc_pages() failures reported due to fragmentation
We have seen a couple of __alloc_pages() failures due to fragmentation, there is plenty of free memory but no large order pages available. I think the problem is in sock_alloc_send_pskb(), the gfp_mask includes __GFP_REPEAT but its never used/passed to the page allocator. Shouldnt the gfp_mask be passed to alloc_skb() ? Signed-off-by: Larry Woodman <lwoodman@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/sock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/sock.c b/net/core/sock.c
index d472db4776c3..ee6cd2541d35 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1160,7 +1160,7 @@ static struct sk_buff *sock_alloc_send_pskb(struct sock *sk,
goto failure;
if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) {
- skb = alloc_skb(header_len, sk->sk_allocation);
+ skb = alloc_skb(header_len, gfp_mask);
if (skb) {
int npages;
int i;