diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2014-05-30 21:35:53 +0400 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2014-05-30 21:35:53 +0400 |
| commit | eb5685f0de4702e44a8b262f1acaea52ef99271a (patch) | |
| tree | 9705ff6180e6074a36150c41ce61bbc531f412f7 | |
| parent | afa63252b2ab85614929405971105c3b20d675ba (diff) | |
| download | linux-eb5685f0de4702e44a8b262f1acaea52ef99271a.tar.xz | |
vfio/pci: Fix unchecked return value
There's nothing we can do different if pci_load_and_free_saved_state()
fails, other than maybe print some log message, but the actual re-load
of the state is an unnecessary step here since we've only just saved
it. We can cleanup a coverity warning and eliminate the unnecessary
step by freeing the state ourselves.
Detected by Coverity: CID 753101
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
| -rw-r--r-- | drivers/vfio/pci/vfio_pci.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 7ba042498857..85063f1c12d7 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -57,7 +57,8 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev) ret = vfio_config_init(vdev); if (ret) { - pci_load_and_free_saved_state(pdev, &vdev->pci_saved_state); + kfree(vdev->pci_saved_state); + vdev->pci_saved_state = NULL; pci_disable_device(pdev); return ret; } |