summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReto Schneider <code@reto-schneider.ch>2020-06-22 16:21:12 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-09-03 12:19:24 +0300
commitab75ab9165de8fb8d037454856afb165e8d8b06d (patch)
treeb2e50b64eb6fada2afce2b005dc3cd1bfa9799e3
parentd22aec437d771dc6b57b73ef14454a1aef44fa8c (diff)
downloadlinux-ab75ab9165de8fb8d037454856afb165e8d8b06d.tar.xz
rtlwifi: rtl8192cu: Prevent leaking urb
[ Upstream commit 03128643eb5453a798db5770952c73dc64fcaf00 ] If usb_submit_urb fails the allocated urb should be unanchored and released. Signed-off-by: Reto Schneider <code@reto-schneider.ch> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200622132113.14508-3-code@reto-schneider.ch Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/wireless/realtek/rtlwifi/usb.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 9408c1f8e397..f01ef8ecfaf3 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -755,8 +755,11 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw)
usb_anchor_urb(urb, &rtlusb->rx_submitted);
err = usb_submit_urb(urb, GFP_KERNEL);
- if (err)
+ if (err) {
+ usb_unanchor_urb(urb);
+ usb_free_urb(urb);
goto err_out;
+ }
usb_free_urb(urb);
}
return 0;