diff options
| author | Eric W. Biederman <ebiederm@aristanetworks.com> | 2011-03-22 04:24:53 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-03-22 04:24:53 +0300 |
| commit | 675071a2ef3f4a6d25ee002a7437d50431168344 (patch) | |
| tree | 54399646ea81261585fa8889b6d744cec0a8a3a8 | |
| parent | 9d2a8fa96a44ba242de3a6f56acaef7a40a97b97 (diff) | |
| download | linux-675071a2ef3f4a6d25ee002a7437d50431168344.tar.xz | |
veth: Fix the byte counters
Commit 44540960 "veth: move loopback logic to common location" introduced
a bug in the packet counters. I don't understand why that happened as it
is not explained in the comments and the mut check in dev_forward_skb
retains the assumption that skb->len is the total length of the packet.
I just measured this emperically by setting up a veth pair between two
noop network namespaces setting and attempting a telnet connection between
the two. I saw three packets in each direction and the byte counters were
exactly 14*3 = 42 bytes high in each direction. I got the actual
packet lengths with tcpdump.
So remove the extra ETH_HLEN from the veth byte count totals.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/veth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 105d7f0630cc..2de9b90c5f8f 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -171,7 +171,7 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev) if (skb->ip_summed == CHECKSUM_NONE) skb->ip_summed = rcv_priv->ip_summed; - length = skb->len + ETH_HLEN; + length = skb->len; if (dev_forward_skb(rcv, skb) != NET_RX_SUCCESS) goto rx_drop; |