diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-01-29 17:18:51 +0400 |
|---|---|---|
| committer | Roland Dreier <roland@purestorage.com> | 2014-02-14 21:48:09 +0400 |
| commit | fd8b48b22a2b7cdf21f15b01cae379e6159a7eea (patch) | |
| tree | e3dcca0a35abce2741e8540c45fb0f8990a5e887 | |
| parent | 7d9eacf9457efc6b614665e1095336c11ad83f0d (diff) | |
| download | linux-fd8b48b22a2b7cdf21f15b01cae379e6159a7eea.tar.xz | |
IB/iser: Fix use after free in iser_snd_completion()
We use "tx_desc" again after we free it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
| -rw-r--r-- | drivers/infiniband/ulp/iser/iser_initiator.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 538822684d5b..334f34b1cd46 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -610,11 +610,12 @@ void iser_snd_completion(struct iser_tx_desc *tx_desc, ib_dma_unmap_single(device->ib_device, tx_desc->dma_addr, ISER_HEADERS_LEN, DMA_TO_DEVICE); kmem_cache_free(ig.desc_cache, tx_desc); + tx_desc = NULL; } atomic_dec(&ib_conn->post_send_buf_count); - if (tx_desc->type == ISCSI_TX_CONTROL) { + if (tx_desc && tx_desc->type == ISCSI_TX_CONTROL) { /* this arithmetic is legal by libiscsi dd_data allocation */ task = (void *) ((long)(void *)tx_desc - sizeof(struct iscsi_task)); |