diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2013-02-02 00:57:47 +0400 |
|---|---|---|
| committer | Josef Bacik <jbacik@fusionio.com> | 2013-02-20 21:59:31 +0400 |
| commit | 925396ecf251432d6d0f703a6cfd0cb9e651d936 (patch) | |
| tree | 046fc18a32543d07aad52383afcd26c462ce12af | |
| parent | 0bec9ef525e33233d7739b71be83bb78746f6e94 (diff) | |
| download | linux-925396ecf251432d6d0f703a6cfd0cb9e651d936.tar.xz | |
Btrfs: account for orphan inodes properly during cleanup
Dave sent me a panic where we were doing the orphan cleanup and panic'ed
trying to release our reservation from the orphan block rsv. The reason for
this is because our orphan block rsv had been free'd out from underneath us
because the transaction commit found that there were no orphan inodes
according to its count and decided to free it. This is incorrect so make
sure we inc the orphan inodes count so the accounting is all done properly.
This would also cause the warning in the orphan commit code normally if you
had any orphans to cleanup as they would only decrement the orphan count so
you'd get a negative orphan count which could cause problems during runtime.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
| -rw-r--r-- | fs/btrfs/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 2b48d2d51d50..2dc59734e071 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -2502,6 +2502,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) */ set_bit(BTRFS_INODE_HAS_ORPHAN_ITEM, &BTRFS_I(inode)->runtime_flags); + atomic_inc(&root->orphan_inodes); /* if we have links, this was a truncate, lets do that */ if (inode->i_nlink) { |