diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2019-01-13 12:44:50 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-23 10:09:49 +0300 |
| commit | a7c0d6db36380165a4f1586c874dbb09285c933f (patch) | |
| tree | e30c4af9f08e01f869220d43d92ef6c9b630d115 | |
| parent | a06d94d98d2417510ab2dab39f633d6557b0bb68 (diff) | |
| download | linux-a7c0d6db36380165a4f1586c874dbb09285c933f.tar.xz | |
OF: properties: add missing of_node_put
commit 28b170e88bc0c7509e6724717c15cb4b5686026e upstream.
Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.
The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
when != true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/of/property.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/of/property.c b/drivers/of/property.c index 264c355ba1ff..fd9b734fff33 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -810,6 +810,7 @@ struct device_node *of_graph_get_remote_node(const struct device_node *node, if (!of_device_is_available(remote)) { pr_debug("not available for remote node\n"); + of_node_put(remote); return NULL; } |