diff options
| author | Miquel Raynal <miquel.raynal@bootlin.com> | 2022-01-25 15:14:24 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-08 20:16:29 +0300 |
| commit | a1c277b0ed2a13e7de923b5f03bc23586eceb851 (patch) | |
| tree | c258797717f16634c58c4c8934d8c8dd22594837 | |
| parent | a44ae6b73994bfc5e378497aaa0431d55cefc958 (diff) | |
| download | linux-a1c277b0ed2a13e7de923b5f03bc23586eceb851.tar.xz | |
net: ieee802154: ca8210: Stop leaking skb's
commit 621b24b09eb61c63f262da0c9c5f0e93348897e5 upstream.
Upon error the ieee802154_xmit_complete() helper is not called. Only
ieee802154_wake_queue() is called manually. We then leak the skb
structure.
Free the skb structure upon error before returning.
Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20220125121426.848337-5-miquel.raynal@bootlin.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/ieee802154/ca8210.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 368369469e32..893a5787d81d 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1770,6 +1770,7 @@ static int ca8210_async_xmit_complete( status ); if (status != MAC_TRANSACTION_OVERFLOW) { + dev_kfree_skb_any(priv->tx_skb); ieee802154_wake_queue(priv->hw); return 0; } |