diff options
| author | Colin Ian King <colin.king@canonical.com> | 2014-08-25 00:38:35 +0400 |
|---|---|---|
| committer | Will Deacon <will.deacon@arm.com> | 2014-08-26 14:42:22 +0400 |
| commit | 031cb428383b2fcf36a4ce09aeedaa548d9ed1d1 (patch) | |
| tree | ddffeb591e1bcf14de716469a99181e58699b3b9 | |
| parent | 52addcf9d6669fa439387610bc65c92fa0980cef (diff) | |
| download | linux-031cb428383b2fcf36a4ce09aeedaa548d9ed1d1.tar.xz | |
arm64/crypto: remove redundant update of data
Originally found by cppcheck:
[arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of
function parameter has no effect outside the function. Did you
forget dereferencing it?
Updating data by blocks * SHA256_BLOCK_SIZE at the end of
sha2_finup is redundant code and can be removed.
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
| -rw-r--r-- | arch/arm64/crypto/sha2-ce-glue.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c index c294e67d3925..ae67e88c28b9 100644 --- a/arch/arm64/crypto/sha2-ce-glue.c +++ b/arch/arm64/crypto/sha2-ce-glue.c @@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data, kernel_neon_begin_partial(28); sha2_ce_transform(blocks, data, sctx->state, NULL, len); kernel_neon_end(); - data += blocks * SHA256_BLOCK_SIZE; } static int sha224_finup(struct shash_desc *desc, const u8 *data, |