diff options
author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-09-16 17:07:26 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-17 16:26:59 +0300 |
commit | bbc85a9d48ddc171d05566b3460c4228ca452904 (patch) | |
tree | 14f1f9a04e19230638127e5c4390ce68329be06c | |
parent | 444a5568684d2c56316bef894efb2ae7c88c037e (diff) | |
download | linux-bbc85a9d48ddc171d05566b3460c4228ca452904.tar.xz |
OPP: fix error code in dev_pm_opp_set_config()
commit eb8333673e1ebc2418980b664a84c91b4e98afc4 upstream.
This is an error path so set the error code. Smatch complains about the
current code:
drivers/opp/core.c:2660 dev_pm_opp_set_config()
error: uninitialized symbol 'ret'.
Fixes: e37440e7e2c2 ("OPP: Call dev_pm_opp_set_opp() for required OPPs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/3f3660af-4ea0-4a89-b3b7-58de7b16d7a5@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/opp/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 494f8860220d..3aa18737470f 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2630,8 +2630,10 @@ int dev_pm_opp_set_config(struct device *dev, struct dev_pm_opp_config *config) /* Attach genpds */ if (config->genpd_names) { - if (config->required_devs) + if (config->required_devs) { + ret = -EINVAL; goto err; + } ret = _opp_attach_genpd(opp_table, dev, config->genpd_names, config->virt_devs); |