summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2024-08-01 09:42:01 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-10 13:01:13 +0300
commit41e7dd6fb6f82e2a145ce8d05610e4a6e7df2808 (patch)
treefe93573ae5eb4898f28f339b2d7afb02528dd94c
parent00fb5b23e1c9cdbe496f5cd6b40367cb895f6c93 (diff)
downloadlinux-41e7dd6fb6f82e2a145ce8d05610e4a6e7df2808.tar.xz
ALSA: control: Fix leftover snd_power_unref()
commit fef1ac950c600ba50ef4d65ca03c8dae9be7f9ea upstream. One snd_power_unref() was forgotten and left at __snd_ctl_elem_info() in the previous change for reorganizing the locking order. Fixes: fcc62b19104a ("ALSA: control: Take power_ref lock primarily") Link: https://github.com/thesofproject/linux/pull/5127 Link: https://patch.msgid.link/20240801064203.30284-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--sound/core/control.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/core/control.c b/sound/core/control.c
index 2151f19b432f..c18a9e6539b3 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1165,7 +1165,6 @@ static int __snd_ctl_elem_info(struct snd_card *card,
info->access = 0;
#endif
result = kctl->info(kctl, info);
- snd_power_unref(card);
if (result >= 0) {
snd_BUG_ON(info->access);
index_offset = snd_ctl_get_ioff(kctl, &info->id);