diff options
| author | Haiyang Zhang <haiyangz@microsoft.com> | 2019-10-30 18:32:13 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-12 21:28:14 +0300 |
| commit | cf0ccb042e9ea3e6a156b753292b4d3e80bfeef9 (patch) | |
| tree | b46395bc2d0ee9571b69c9ea82d65132a27df62e | |
| parent | 7fc9c5338bf43ba2cd80e4d704f6923bbad60a83 (diff) | |
| download | linux-cf0ccb042e9ea3e6a156b753292b4d3e80bfeef9.tar.xz | |
hv_netvsc: Fix error handling in netvsc_attach()
[ Upstream commit 719b85c336ed35565d0f3982269d6f684087bb00 ]
If rndis_filter_open() fails, we need to remove the rndis device created
in earlier steps, before returning an error code. Otherwise, the retry of
netvsc_attach() from its callers will fail and hang.
Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/hyperv/netvsc_drv.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index e8fce6d715ef..8ed79b418d88 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -982,7 +982,7 @@ static int netvsc_attach(struct net_device *ndev, if (netif_running(ndev)) { ret = rndis_filter_open(nvdev); if (ret) - return ret; + goto err; rdev = nvdev->extension; if (!rdev->link_state) @@ -990,6 +990,13 @@ static int netvsc_attach(struct net_device *ndev, } return 0; + +err: + netif_device_detach(ndev); + + rndis_filter_device_remove(hdev, nvdev); + + return ret; } static int netvsc_set_channels(struct net_device *net, |