summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 22:34:54 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-13 10:49:33 +0300
commit86d280b5709fea45ece6b47e1f30a2ff4800bee9 (patch)
tree8c755d831bda199a4a37d59c366533f9d472d531
parentceddd48c8407c4d1c70a815ae229f34c9af44273 (diff)
downloadlinux-86d280b5709fea45ece6b47e1f30a2ff4800bee9.tar.xz
crypto: user - fix memory leak in crypto_reportstat
commit c03b04dcdba1da39903e23cc4d072abf8f68f2dd upstream. In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is leaked if crypto_reportstat_alg() fails. Required release for skb is added. Fixes: cac5818c25d0 ("crypto: user - Implement a generic crypto statistics") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--crypto/crypto_user_stat.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index a03f326a63d3..30f77cf9122d 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -326,8 +326,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}