diff options
| author | Salva Peiró <speiro@ai2.upv.es> | 2013-12-17 13:06:30 +0400 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-02-15 23:20:09 +0400 |
| commit | 794ce89c4585d8679fae8c06ddabf8d3a4c4fa53 (patch) | |
| tree | e11cd5f6b5d51573269dc14e5decea7989480ad0 | |
| parent | 6ea9c09b5c3b6248ae4fed3240e6aefbefa2169b (diff) | |
| download | linux-794ce89c4585d8679fae8c06ddabf8d3a4c4fa53.tar.xz | |
hamradio/yam: fix info leak in ioctl
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ]
The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/net/hamradio/yam.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 96a98d2ff151..e4260ab421f1 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1060,6 +1060,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; case SIOCYAMGCFG: + memset(&yi, 0, sizeof(yi)); yi.cfg.mask = 0xffffffff; yi.cfg.iobase = yp->iobase; yi.cfg.irq = yp->irq; |