diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2014-04-02 19:45:05 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-04-23 03:49:20 +0400 |
| commit | 5c4c9c02f83a7b139cb45fe4356741f162a4ac38 (patch) | |
| tree | a8df0aac2796247e119122d6c14ba89249a4d0a8 | |
| parent | d8e33d97e0166d8cd521daa83ae33f85001a6e33 (diff) | |
| download | linux-5c4c9c02f83a7b139cb45fe4356741f162a4ac38.tar.xz | |
pid_namespace: pidns_get() should check task_active_pid_ns() != NULL
commit d23082257d83e4bc89727d5aedee197e907999d2 upstream.
pidns_get()->get_pid_ns() can hit ns == NULL. This task_struct can't
go away, but task_active_pid_ns(task) is NULL if release_task(task)
was already called. Alternatively we could change get_pid_ns(ns) to
check ns != NULL, but it seems that other callers are fine.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | kernel/pid_namespace.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index 06c62de9c711..db95d8eb761b 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -318,7 +318,9 @@ static void *pidns_get(struct task_struct *task) struct pid_namespace *ns; rcu_read_lock(); - ns = get_pid_ns(task_active_pid_ns(task)); + ns = task_active_pid_ns(task); + if (ns) + get_pid_ns(ns); rcu_read_unlock(); return ns; |