diff options
author | Chema Gonzalez <chema@google.com> | 2014-05-30 21:15:12 +0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-03 03:32:43 +0400 |
commit | e9d9450497f77ee40c7d895bf1b5b134b9347d5f (patch) | |
tree | 5b56ae0ed1e7cc3b4ff1aaf4f41d141c026af380 /.mailmap | |
parent | f7b4e71c9d6154969270d8bbd49e78ca86d455cd (diff) | |
download | linux-e9d9450497f77ee40c7d895bf1b5b134b9347d5f.tar.xz |
net: filter: fix length calculation in BPF testsuite
The current probe_filter_length() (the function that calculates the
length of a test BPF filter) behavior is to declare the end of the
filter as soon as it finds {0, *, *, 0}. This is actually a valid
insn ("ld #0"), so any filter with includes "BPF_STMT(BPF_LD | BPF_IMM, 0)"
fails (its length is cut short).
We are changing probe_filter_length() so as to start from the end, and
declare the end of the filter as the first instruction which is not
{0, *, *, 0}. This solution produces a simpler patch than the
alternative of using an explicit end-of-filter mark. It is technically
incorrect if your filter ends up with "ld #0", but that should not
happen anyway.
We also add a new test (LD_IMM_0) that includes ld #0 (does not work
without this patch).
Signed-off-by: Chema Gonzalez <chema@google.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions