diff options
author | Amir Goldstein <amir73il@gmail.com> | 2018-01-26 22:24:40 +0300 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-01-29 18:27:23 +0300 |
commit | acd1d71598f7654b6d7718bcbe979992295c672a (patch) | |
tree | db35d8607f69ef0531ea53b05fa552cf671d1919 /.gitignore | |
parent | 751f3767c245f9adf4f0a4f8f04aae9ae1d675a0 (diff) | |
download | linux-acd1d71598f7654b6d7718bcbe979992295c672a.tar.xz |
xfs: preserve i_rdev when recycling a reclaimable inode
Commit 66f364649d870 ("xfs: remove if_rdev") moved storing of rdev
value for special inodes to VFS inodes, but forgot to preserve the
value of i_rdev when recycling a reclaimable xfs_inode.
This was detected by xfstest overlay/017 with inodex=on mount option
and xfs base fs. The test does a lookup of overlay chardev and blockdev
right after drop caches.
Overlayfs inodes hold a reference on underlying xfs inodes when mount
option index=on is configured. If drop caches reclaim xfs inodes, before
it relclaims overlayfs inodes, that can sometimes leave a reclaimable xfs
inode and that test hits that case quite often.
When that happens, the xfs inode cache remains broken (zere i_rdev)
until the next cycle mount or drop caches.
Fixes: 66f364649d870 ("xfs: remove if_rdev")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions