diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2017-09-28 21:19:06 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-01 06:01:29 +0300 |
| commit | 21a2774ef5d4fde772fbcb9d0eabb76f585e5af5 (patch) | |
| tree | 524c7150e4b645ac4cb7eac62e0ea55d825e7742 /.get_maintainer.ignore | |
| parent | a6992ebee4a7ef6e714af82f22a2ca3f797bb9e4 (diff) | |
| download | linux-21a2774ef5d4fde772fbcb9d0eabb76f585e5af5.tar.xz | |
Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable"
This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port
enabling to calling port_enable") because this now makes an unbind
followed by a bind to fail connecting to the ingrated PHY.
What this patch missed is that we need the PHY to be enabled with
bcm_sf2_gphy_enable_set() before probing it on the MDIO bus. This is
correctly done in the ops->setup() function, but by the time
ops->port_enable() runs, this is too late. Upon unbind we would power
down the PHY, and so when we would bind again, the PHY would be left
powered off.
Fixes: e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '.get_maintainer.ignore')
0 files changed, 0 insertions, 0 deletions