diff options
author | Tejun Heo <tj@kernel.org> | 2018-01-09 19:29:50 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-01-09 19:31:15 +0300 |
commit | 358f70da49d77c43f2ca11b5da584213b2add29c (patch) | |
tree | 51278948dbff954a8cede7523bf06a38dbb8051a /.cocciconfig | |
parent | 67818d25738b1c9ffb8541ca875b2ae3304869d5 (diff) | |
download | linux-358f70da49d77c43f2ca11b5da584213b2add29c.tar.xz |
blk-mq: make blk_abort_request() trigger timeout path
With issue/complete and timeout paths now using the generation number
and state based synchronization, blk_abort_request() is the only one
which depends on REQ_ATOM_COMPLETE for arbitrating completion.
There's no reason for blk_abort_request() to be a completely separate
path. This patch makes blk_abort_request() piggyback on the timeout
path instead of trying to terminate the request directly.
This removes the last dependency on REQ_ATOM_COMPLETE in blk-mq.
Note that this makes blk_abort_request() asynchronous - it initiates
abortion but the actual termination will happen after a short while,
even when the caller owns the request. AFAICS, SCSI and ATA should be
fine with that and I think mtip32xx and dasd should be safe but not
completely sure. It'd be great if people who know the drivers take a
look.
v2: - Add comment explaining the lack of synchronization around
->deadline update as requested by Bart.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Asai Thambi SP <asamymuthupa@micron.com>
Cc: Stefan Haberland <sth@linux.vnet.ibm.com>
Cc: Jan Hoeppner <hoeppner@linux.vnet.ibm.com>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions