diff options
| author | Tommi Rantala <tommi.t.rantala@nokia.com> | 2020-03-12 17:43:53 +0300 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2020-03-13 20:37:13 +0300 |
| commit | 3d28e7e278913a267b1de360efcd5e5274065ce2 (patch) | |
| tree | a272dbc5868529172a2cad79fae983cc3202f493 /.clang-format | |
| parent | 17bb60b74124e9491d593e2601e3afe14daa2f57 (diff) | |
| download | linux-3d28e7e278913a267b1de360efcd5e5274065ce2.tar.xz | |
xfs: fix regression in "cleanup xfs_dir2_block_getdents"
Commit 263dde869bd09 ("xfs: cleanup xfs_dir2_block_getdents") introduced
a getdents regression, when it converted the pointer arithmetics to
offset calculations: offset is updated in the loop already for the next
iteration, but the updated offset value is used incorrectly in two
places, where we should have used the not-yet-updated value.
This caused for example "git clean -ffdx" failures to cleanup certain
directory structures when running in a container.
Fix the regression by making sure we use proper offset in the loop body.
Thanks to Christoph Hellwig for suggestion how to best fix the code.
Cc: Christoph Hellwig <hch@lst.de>
Fixes: 263dde869bd09 ("xfs: cleanup xfs_dir2_block_getdents")
Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to '.clang-format')
0 files changed, 0 insertions, 0 deletions